Series sales form: buyer and seller must be different

[php-coder]

Steps to reproduce:

• login as admin
• open page with series info
• fill series sales form with similar seller/buyer

Expected result:

• error should be shown

Actual result:

• form submitted successfully

Tech debt for: fe9f30d (#198)

[php-coder]

@Smetanin I'm suggesting you to work on this issue. If you're agree then assign it to yourself and add label in-progress.

The first step will be to reproduce validation issue. After that you need to write a validator to fix the issue. Actually, looks like that we already have similar validator that could be re-used. Look at FieldsMismatch and FieldsMismatchValidator

This is work flow instruction: https://github.com/php-coder/mystamps/wiki/dev_quick_start_continue

If you want some theory about validation, here are the links to documentation:

• Creating custom constraints
• Java Bean Validation Basics

[php-coder]

Here is also example for how to use FieldsMismatch validator:

mystamps/src/main/java/ru/mystamps/web/feature/account/ActivateAccountForm.java

Lines 33 to 45 in d425827

	@FieldsMismatch(
	first = "login",
	second = "password",
	message = "{password.login.match}",
	groups = ActivateAccountForm.FormChecks.class
	)
	@FieldsMatch(
	first = "password",
	second = "passwordConfirmation",
	message = "{password.mismatch}",
	groups = ActivateAccountForm.FormChecks.class
	)
	public class ActivateAccountForm implements ActivateAccountDto {

[KrivenkoAlexander]

@php-coder could you advise me where i can find this page * open page with series info ?
Do i right understand that this is the form

And we can't have the similar sales, right ? The example of bad case is : I created the two similar sales with Eicca Toppinen and John Conor with the same sum of selling .

[php-coder]

could you advise me where i can find this page * open page with series info ?

It's /series/1 for example.

Do i right understand that this is the form

Yes, it is.

And we can't have the similar sales, right ? The example of bad case is : I created the two similar sales with Eicca Toppinen and John Conor with the same sum of selling .

We can't have a series sale where a buyer is the same as a seller. Example: we can't create a sale with Eicca Toppinen as a seller and Eicca Toppinen as a buyer at the same time.