Skip to content

Port integration tests to Robot Framework #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
34 tasks done
php-coder opened this issue Jan 12, 2017 · 3 comments
Closed
34 tasks done

Port integration tests to Robot Framework #530

php-coder opened this issue Jan 12, 2017 · 3 comments

Comments

@php-coder
Copy link
Owner

php-coder commented Jan 12, 2017

After couple attempts to port all integration tests to Thucydides/Serenity/Cucumber-JVM (see #18) I concluded that:

  • all work should be merged into the master as fast as possible
  • probably we shouldn't use only one framework for all integration tests (but we will)

Based on this, the current view is to port most of the integration tests to Robot Framework (because the tests are easy to write) and port another portion of tests to Cucumber-JVM (later we'll be able to compare them). (no, we don't want to maintain 2 frameworks for the same purpose: #1019)

Plan

Port the existing tests

  • port WhenAdminAddCategory
  • port WhenAnonymousUserAddCategory
  • port WhenAnonymousUserOpenNotExistingCategoryPage
  • port WhenAdminAddCountry
  • port WhenAnonymousUserAddCountry
  • port WhenAnonymousUserOpenNotExistingCountryPage
  • port WhenAdminAddSeries
  • port WhenAnonymousUserAddSeries
  • port WhenAnonymousUserOpenNotExistingSeriesPage
  • port WhenAdminAtIndexPage
  • port WhenAnonymousUserActivateAccount
  • port WhenAnonymousUserAtForbiddenPage
  • port WhenAnonymousUserAtIndexPage
  • port WhenAnonymousUserAuthenticates
  • port WhenAnonymousUserOpenNotExistingCollectionPage
  • port WhenAnonymousUserOpenNotExistingPage
  • port WhenAnonymousUserOpenTogglzConsole
  • port WhenAnonymousUserRegisterAccount (successfulMessageShouldBeShownAfterRegistration and emailWithActivationKeyShouldBeSentAfterRegistration) (depends on Mailgun: send e-mail via API #935)
  • port WhenUserAddSeries
  • port WhenUserAtActivateAccountPage
  • port WhenUserAtAuthPage
  • port WhenUserAtIndexPage
  • port WhenUserAtRegisterAccountPage
  • port WhenUserLogsOut
  • port WhenUserOpenTogglzConsole

Other work

@php-coder php-coder added this to the next milestone Jan 12, 2017
@php-coder php-coder self-assigned this Jan 12, 2017
php-coder added a commit that referenced this issue Jan 13, 2017
php-coder added a commit that referenced this issue Jan 13, 2017
php-coder added a commit that referenced this issue Jan 13, 2017
… to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 13, 2017
php-coder added a commit that referenced this issue Jan 13, 2017
…ries: port to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 13, 2017
…ries: port to Robot Framework.

Addressed to #530

No functional changes.
@php-coder
Copy link
Owner Author

php-coder commented Jan 13, 2017

Improvements for tests:

  • Create category with name in English: verify that after changing language, header will be in English
  • Create category with name in English and Russian: verify that after changing language, header will be in Russian
  • category/creation/{logic,validation}: log in as user (instead of admin)
  • re-apply shouldHaveTitle to the index page
  • re-apply shouldHaveUserBar to the index page
  • re-apply shouldHaveContentArea to the index page
  • re-apply shouldHaveLogo to the index page
  • re-apply shouldHaveFooter to the index page

UPDATE(26.05.2019): most of them seem no needed now.

php-coder added a commit that referenced this issue Jan 13, 2017
…Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 13, 2017
…obot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 13, 2017
… Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 13, 2017
php-coder added a commit that referenced this issue Jan 13, 2017
…ns: port to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 13, 2017
…BeRejected: port to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 13, 2017
…ns: port to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 14, 2017
…rt to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 14, 2017
… to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 14, 2017
…TrailingSpaces: port to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 14, 2017
…TrailingSpaces: port to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 14, 2017
…One: port to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 14, 2017
…One: port to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 14, 2017
…bot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 14, 2017
…ot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue Jan 14, 2017
…Rejected: port to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 5, 2019
…redAsInvalidCredentials() to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 5, 2019
…Rejected() to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 5, 2019
…enticateUserOnSite() to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 5, 2019
This test doesn't provide much value and it's better to remove it rather
than port to Robot Framework. Also, it's identical to the existing
"Anonymous user don't have access to Togglz console" test case.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 5, 2019
This test doesn't provide much value and it's better to remove it rather
than port to Robot Framework. Also, we already have the tests for
checking that 404 page is shown, so we won't miss the possible errors on
that page.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 5, 2019
Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 5, 2019
Should be in 318d520 commit.

Related to #530

No functional changes.
php-coder added a commit that referenced this issue May 6, 2019
…ong() to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 6, 2019
… to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 6, 2019
…hLinkToAuthenticationPage() test.

This test doesn't provide much value and it's better to remove it rather
than port to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 6, 2019
…FromLeadingAndTrailingSpaces() to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 6, 2019
…es() to Robot Framework.

Also remove a similar test from misc-admin.robot: one test for
that case is enough. If this will be broken only for admin it
won't be so critical as when it's broken for users.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 6, 2019
…aces() to Robot Framework.

Also remove a similar test from misc-admin.robot: one test for
that case is enough. If this will be broken only for admin it
won't be so critical as when it's broken for users.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 7, 2019
…s() to Robot Framework.

Also remove a similar test from misc-admin.robot: one test for
that case is enough. If this will be broken only for admin it
won't be so critical as when it's broken for users.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 7, 2019
… to Robot Framework.

Also remove a similar test from misc-admin.robot: one test for
that case is enough. If this will be broken only for admin it
won't be so critical as when it's broken for users.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 7, 2019
php-coder added a commit that referenced this issue May 7, 2019
…ieldsFilled() to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 7, 2019
…ed() to Robot Framework.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 26, 2019
php-coder added a commit that referenced this issue May 26, 2019
Ensuring that functionality works under user is more important than under admin.

Addressed to #530

No functional changes.
php-coder added a commit that referenced this issue May 26, 2019
Should be in 091877e commit.

Addressed to #530

No functional changes.
@php-coder
Copy link
Owner Author

I think that we done here! 🎉

@php-coder php-coder unpinned this issue May 26, 2019
php-coder added a commit that referenced this issue Nov 6, 2019
…essary now.

htmlunit loggers aren't used since #530 when we migrated away of integration tests on Java.

Regarding DefaultTestContextBootstrapper I'm not sure, perhaps it was related to them too as we used
Spring context for these tests. Maybe be it wasn't related but it isn't clear why we need this now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant