Skip to content

StepDefinitions.seriesAddedToCollection(): rename method #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Sep 25, 2017 · 2 comments
Closed

StepDefinitions.seriesAddedToCollection(): rename method #643

php-coder opened this issue Sep 25, 2017 · 2 comments
Assignees
@olithin
Labels
area/integration tests refactoring techdebt trivial
Milestone
0.4

Comments

@php-coder
Copy link
Owner

php-coder commented Sep 25, 2017 •
edited
Loading

Method seriesAddedToCollection() should be renamed to seriesHasBeenAddedToCollection() because the latter name is more grammatically correct in English.

Tech debt for f72c87d (#46)
@php-coder php-coder added this to the next milestone Sep 25, 2017
@olithin
Copy link

olithin commented Nov 29, 2017 •
edited
Loading

fixed in branch - task644

@php-coder php-coder modified the milestones: next, 0.4 Nov 29, 2017
@php-coder
Copy link
Owner Author

@Goblic brunch it's something between breakfast and lunch ;) it should be "branch".

@olithin olithin mentioned this issue Nov 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olithin olithin

Labels
area/integration tests refactoring techdebt trivial
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @olithin