Skip to content

Migrate to Selenium3 #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 23, 2019
Merged

Migrate to Selenium3 #1118

merged 10 commits into from
Sep 23, 2019

Conversation

php-coder
Copy link
Owner

@php-coder php-coder commented Sep 8, 2019 •
edited
Loading

@mukeshk JFYI

Fixes #1001
Also fixes #540, fixes #542, fixes #546, fixes #556, fixes #557, fixes #650 and fixes #667

@mystamps-bot
Copy link

mystamps-bot commented Sep 9, 2019 •
edited
Loading

3 Warnings
⚠️ danger check: pull request description doesn’t contain a link to original issue.
Consider adding a comment in the following format: Addressed to #XXX where XXX is an issue number
⚠️ danger check: pull request contains 10 commits while most of the cases it should have only one. If it’s not a special case you should squash the commits into single one.
But be careful because it can destroy all your changes!
⚠️ danger check: branch selenium3 does not comply with our best practices. Branch name should use the following scheme: ghXXX_meaningful-name where XXX is an issue number. Next time, please, use this scheme :)

Generated by 🚫 Danger

@php-coder php-coder force-pushed the selenium3 branch 4 times, most recently from 07b7bb5 to 15e6b2f Compare September 13, 2019 23:41
@php-coder
build: update Robot Framework and integration tests to use Selenium 3.
c804045 
This change updates:
- robotframework-seleniumlibrary to 3.141.59.2653
- robotframework-maven-plugin to 1.5.1
- robotframework to 3.1.2
- selenium to 3.141.59
- htmlunit-driver to 2.36.0
- htmlunit to 2.36.0

Changelogs:
- robotframework-seleniumlibrary
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.5.3.0
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.5.3.1
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.5.3.2
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.6.0.0
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.7.1.0
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.7.1.1
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.7.1.2
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.7.1.3
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.8.1.0
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.8.1.1
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.9.1.0
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.12.0.0
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.12.0.1
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.14.0.0
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.141.59.2
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.141.59.26
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.141.59.265
  * https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/releases/tag/3.141.59.2653
- robotframework-maven-plugin
  * https://github.com/robotframework/MavenPlugin/releases/tag/1.4.8
  * https://github.com/robotframework/MavenPlugin/releases/tag/1.4.9
  * https://github.com/robotframework/MavenPlugin/releases/tag/1.5.0
  * https://github.com/robotframework/MavenPlugin/releases/tag/1.5.1
- robotframework
  * https://github.com/robotframework/robotframework/blob/master/doc/releasenotes/rf-3.1.rst
  * https://github.com/robotframework/robotframework/blob/master/doc/releasenotes/rf-3.1.1.rst
  * https://github.com/robotframework/robotframework/blob/master/doc/releasenotes/rf-3.1.2.rst
- selenium
  * https://github.com/SeleniumHQ/selenium/blob/selenium-3.141.59/java/CHANGELOG
- htmlunit-driver
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.22
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.23
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.23.1
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.23.2
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.24
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.25
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.26
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.27
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.28
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.28.1
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.28.2
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.28.3
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.28.4
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.28.5
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.29.0
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.29.1
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.29.2
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.29.3
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.30.0
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.30.1
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.31.0
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.32.0
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.32.1
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.33.0
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.33.1
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.33.2
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.33.3
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.34.0
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.35.0
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.35.1
  * https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/2.36.0
- htmlunit
  * http://htmlunit.sourceforge.net/changes-report.html

Fix #1001
@php-coder
test: mark some tests as stable after migration to Selenium 3.
0df8f0b 
Address to #1001
@php-coder
test: mark "Create country with name in English" test as stable after…
02458b0 
… migration to Selenium 3.

Relate to #1001
Close #540
@php-coder php-coder changed the title [WIP] Migrate to Selenium3 Migrate to Selenium3 Sep 22, 2019
@php-coder
Copy link
Owner Author

I started to hate Travis CI that crop the console output time to time so it nearly impossible to debug flakes :(

@php-coder
refactor: use a new way of writing element locators to fix warnings.
7a50400 
Prior this change there were a lot of warnings like the following:
[ WARN ] '=' is deprecated as locator strategy separator. ':' should be used instead

Address to #1001
@php-coder php-coder merged commit 7a50400 into master Sep 23, 2019
@php-coder php-coder deleted the selenium3 branch September 23, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
resolution/merged
Projects
None yet
Milestone
No milestone
2 participants
@php-coder @mystamps-bot