Configure vagrant+ansible

[PI-Victor]

For: #268
Will implement as stated in #267
Signed-off-by: pi-victor ipalade@redhat.com

[php-coder]

Thanks for the PR. Just want to say that you don't need to prepend PR with [WIP] because there are not so many PRs and only one human who merges it :)

P.S. I also modified the description to make it clear what this PR is about.

[php-coder]

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 15 unresolved discussions.

---

.gitignore, line 18 [r1] (raw file):
It looks a strange that you put comment at the end of the file and the excluded pattern at the beginning. Could you put the pattern after the comment?

---

vagrant/inventory, line 1 [r1] (raw file):
Do we really need this file?

---

vagrant/mystamps-base.yml, line 1 [r1] (raw file):
Just use all instead of concrete host name.

---

vagrant/mystamps-base.yml, line 3 [r1] (raw file):
Let' remove these for a now.

---

vagrant/mystamps-base.yml, line 6 [r1] (raw file):
Unused. Remove.

---

vagrant/mystamps-base.yml, line 9 [r1] (raw file):
Let's replace this with single task for showing message with simple text like "Provisioning MyStamps". See http://docs.ansible.com/ansible/debug_module.html

---

vagrant/roles/common/tasks/main.yml, line 6 [r1] (raw file):
We don't need to use role in this task. Also the role name is too broad.

---

vagrant/Vagrantfile, line 2 [r1] (raw file):
Let's remove these comments :)

---

vagrant/Vagrantfile, line 13 [r1] (raw file):
My approach is to use minimal config as possible and add things only when we really need them. Right now I don't see the reason of adding this. Let's remove them.

---

vagrant/Vagrantfile, line 17 [r1] (raw file):
Don't try to add things that we don't need yet.

---

vagrant/Vagrantfile, line 22 [r1] (raw file):
Hm... I have never need this and also I don't see same instructions here: http://docs.ansible.com/ansible/guide_vagrant.html#vagrant-setup

And I don't see this (https://www.vagrantup.com/docs/provisioning/ansible.html) too. Hm.. we don't need to have Ansible on the guest. We should have ansible in the host system.

---

vagrant/Vagrantfile, line 26 [r1] (raw file):
These 2 lined should be removed. We will end up with the super minimal Vagrantfile.

---

vagrant/Vagrantfile, line 27 [r1] (raw file):
Yeah, that the most useful line :)

Let's rename the file to mystamps-vagrant.yml

---

vagrant/Vagrantfile, line 28 [r1] (raw file):
We don't need inventory.

---

vagrant/vars/all, line 0 [r1] (raw file):
I don't think that we need it. At least right now. I suggest to remove this file.

---

Comments from the review on Reviewable.io

[PI-Victor]

👍 i'll refactor accordingly, just so you know most of it were copied directly from my vagrant machine. i'll ping you when i updated it.

[PI-Victor]

sorry man, i can't find the time to work on other projects anymore so i have to let this go.

[php-coder]

No problem! Thank you anyway!