Skip to content

Add integration test for adding series to user's collection #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add integration test for adding series to user's collection #525

wants to merge 1 commit into from

Conversation

olithin
Copy link

@olithin olithin commented Jan 4, 2017

Add integration test for adding series to user's collection

Addressed to #46

@olithin olithin self-assigned this Jan 4, 2017
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a very high-level review. After removing most of the noise (like space related changes), I'll review this more detailed.

@@ -114,7 +114,7 @@ public WhenAdminAddSeries() {

@BeforeClass
public void login() {
page.login(validAdminLogin, validAdminPassword);
page.login(validAdminPassword, validAdminLogin);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks strange.

.travis.yml Outdated
install: true

# Clone repository with a depth of 1 commit.
# https://docs.travis-ci.com/user/customizing-the-build/#Git-Clone-Depth
git:
depth: 1 # default: 50

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.travis.yml file should be changed. Please, remove all these modifications or tell me why do we need them.

Copy link
Author

@olithin olithin Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need help here

pom.xml Outdated
<modelVersion>4.0.0</modelVersion>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't change spaces. You should modify only those lines that you need for the fix.


model.put("addSeriesSalesForm", new AddSeriesSalesForm());
}*/

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be removed.

@@ -48,6 +53,7 @@
@NotNull
private Currency currency;


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes from this file should be reverted. Again, try to reduce your modifications to minimum.

driver.get("http://127.0.0.1:8080/");
driver.findElement(By.linkText("1 item(s)")).click();
if (driver.findElements(By.cssSelector("input.btn.btn-danger")).size() != 0) {
System.out.println("Series is part of your collection");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this System.out.println().

public class StepDefinitions {
WebDriver driver = new FirefoxDriver();
@Given("^as a user$")
public void as_a_user() throws Exception {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these throws Exception from all the methods. I believe that you don't need them.

import org.openqa.selenium.firefox.FirefoxDriver;

public class StepDefinitions {
WebDriver driver = new FirefoxDriver();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Member should be private
  • Let's use htmlunitdriver instead

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оба комментария все еще не исправлены.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если я этот класс делаю приватным, то нет доступа к методам. Тест не проходит.

@@ -0,0 +1,9 @@
Feature: User opens series info page, he should see a button for adding series to collection.

@in12
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove tag.

Given as a user
When I add series to my collection
Then I am on the page with my collection
And I see this series have been added to the collection
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a newline to the end of the file.

Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправь пока то, что написал. Потом еще более детально посмотрю.

Автоматизировать это дело и приделывать к мавен плагину пока можно не делать, давай сначала код причешем.

pom.xml Outdated
<artifactId>selenium-java</artifactId>
</dependency>


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Убери здесь лишнюю строчку.

pom.xml Outdated
@@ -41,6 +67,7 @@
</dependency>

<!-- https://github.com/spring-projects/spring-boot/blob/v1.4.3.RELEASE/spring-boot-starters/spring-boot-starter/pom.xml -->

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Убрала красные, теперь нужно убрать лишние зеленые :)

pom.xml Outdated
@@ -497,33 +524,43 @@

<!-- Redefine default value from spring-boot-dependencies (https://github.com/spring-projects/spring-boot/blob/v1.4.3.RELEASE/spring-boot-dependencies/pom.xml) -->
<selenium.version>2.53.1</selenium.version>
<cucumber-java.version>1.2.5</cucumber-java.version>
<cucumber-junit.version>1.2.5</cucumber-junit.version>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давай объединим эти свойства в одно cucumber.version

pom.xml Outdated
</dependency>
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-java</artifactId>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь нужно явно указать версию (используй selenium.version который уже есть в pom.xml)

pom.xml Outdated
<artifactId>junit</artifactId>
<version>4.12</version>
<scope>test</scope>
</dependency>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно отделить зависимости одной пустой строкой.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И не забудь добавить комментарий перед ней:
<!-- Redefine default value from spring-boot-dependencies (https://github.com/spring-projects/spring-boot/blob/v1.4.3.RELEASE/spring-boot-dependencies/pom.xml) -->


@Given("^as a user$")
public void as_a_user() {
driver.get("http://127.0.0.1:8080/account/auth");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вместо адреса сайта и юрлов для страниц используй константы из класса Url.

driver.findElement(By.id("password")).click();
driver.findElement(By.id("password")).clear();
driver.findElement(By.id("password")).sendKeys("test");
driver.findElement(By.cssSelector("input.btn.btn-primary")).click();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

При написании тестов старайся не использовать ничего кроме id. Если их нет, то будем добавлять. В данном конкретном случае, нужно найти форму по ее id и использовать метод submit().

См. также: http://stackoverflow.com/questions/17530104/selenium-webdriver-submit-vs-click

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этот комментарий все еще актуален.

public void as_a_user() {
driver.get("http://127.0.0.1:8080/account/auth");
driver.findElement(By.id("login")).click();
driver.findElement(By.id("login")).clear();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем мы везде очищаем поля перед вводом текста? Без этого не работало?

@Then("^I see that this series have been added to the collection$")
public void i_see_that_this_series_have_been_added_to_the_collection() {
driver.get("http://127.0.0.1:8080/series/1");
Assert.assertTrue(driver.findElement(By.xpath(".//*[@class='btn btn-danger']//ancestor::form/p[1]")).getText().equals("Series is part of your collection"));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Используй статический импорт для assertTrue(). Посмотрев внимательнее. Используй assertEquals() вместо assertTrue() чтобы в случае падения теста было более вменяемое сообщение.


@Then("^I am on the page with my collection$")
public void i_am_on_the_page_with_my_collection() {
driver.get("http://127.0.0.1:8080/collection/coder");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне казалось, что здесь должна быть проверка того какая страница открыта, а не переход на эту страницу.

@olithin olithin changed the title #46 cucumber ganna 46 cucumber ganna Apr 7, 2017
Copy link
Author

@olithin olithin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

import org.openqa.selenium.firefox.FirefoxDriver;

public class StepDefinitions {
WebDriver driver = new FirefoxDriver();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если я этот класс делаю приватным, то нет доступа к методам. Тест не проходит.

Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавил немного комментариев (внимательно пока не вглядывался, но для начала исправь хотя бы эти). Плюс необходимо исправить ошибки о которых сообщил бот.

pom.xml Outdated
<scope>test</scope>
</dependency>

<!-- Redefine default value from spring-boot-dependencies (https://github.com/spring-projects/spring-boot/blob/v1.4.3.RELEASE/spring-boot-dependencies/pom.xml) -->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.4.3.RELEASE -> v1.4.6.RELEASE

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправлено

pom.xml Outdated

<!-- Redefine default value from spring-boot-dependencies (https://github.com/spring-projects/spring-boot/blob/v1.4.5.RELEASE/spring-boot-dependencies/pom.xml) -->
<servlet-api.version>3.1.0</servlet-api.version>

<skipUnitTests>false</skipUnitTests>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все подобные добавления пустых строк нужно убрать.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправлено


@RunWith(Cucumber.class)
@CucumberOptions(features = "classpath:features")

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Убери здесь пустую строку.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправлено

@RunWith(Cucumber.class)
@CucumberOptions(features = "classpath:features")

public class CucumberRunner {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавь свое авторство с помощью javadoc комментария и тега @author (см. как это сделано в других файлах для примера).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправлено


import static org.junit.Assert.assertEquals;

public class StepDefinitions {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавь комментарий со своим авторством.

driver.findElement(By.id("password")).click();
driver.findElement(By.id("password")).clear();
driver.findElement(By.id("password")).sendKeys("test");
driver.findElement(By.cssSelector("input.btn.btn-primary")).click();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этот комментарий все еще актуален.


@Given("^as a user$")
public void loginAsUser() {
driver.get("http://127.0.0.1:8080/account/auth");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Используй константы из класса Url.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправлено

driver.findElement(By.linkText("1 item(s)")).click();
}
driver.findElement(By.cssSelector("input.btn.btn-success")).click();
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавь пустую строку после, чтобы отделить один метод от другого.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for locator - By.cssSelector("input.btn.btn-success") - I thinck we have to add id

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please, add it.

@Then("^I see that this series have been added to the collection$")
public void i_see_that_this_series_have_been_added_to_the_collection() {
driver.get("http://127.0.0.1:8080/series/1");
String actual = driver.findElement(By.xpath(".//*[@class='btn btn-danger']//ancestor::form/p[1]")).getText();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Никаких xpath-ей не надо, просто добавь id к нужному элементу.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no id

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you can add it.

}

@Then("^I see that this series have been added to the collection$")
public void i_see_that_this_series_have_been_added_to_the_collection() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь и выше -- переименуй методы, чтобы использовать camelCase в именах.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

public void iAddSeriesToMyCollection() {
driver.get("http://127.0.0.1:8080/");
driver.findElement(By.linkText("1 item(s)")).click();
if(driver.findElements(By.cssSelector("input.btn.btn-danger")).size() != 0){
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for locator - By.cssSelector("input.btn.btn-danger") - I thinck we have to add id

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, please, add it then.

@php-coder php-coder changed the title 46 cucumber ganna Add integration test for adding series to user's collection Jun 20, 2017
Repository owner deleted a comment from mystamps-bot Jun 20, 2017
pom.xml Outdated
@@ -516,17 +546,21 @@
<!-- Redefine default value from spring-boot-dependencies (https://github.com/spring-projects/spring-boot/blob/v1.4.6.RELEASE/spring-boot-dependencies/pom.xml) -->
<slf4j.version>1.7.25</slf4j.version>


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why they're still here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

pom.xml Outdated
<scope>test</scope>
</dependency>

<!-- Redefine default value from spring-boot-dependencies (https://github.com/spring-projects/spring-boot/blob/v1.4.6.RELEASE/spring-boot-dependencies/pom.xml) -->
Copy link
Owner

@php-coder php-coder Jun 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should be placed above the property when we're defining the version (<junit.version>4.12</junit.version>) instead of here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

pom.xml Outdated
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-java</artifactId>
<version>${selenium.version}</version>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this dependency because we already have selenium-api. Please, remove it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

import cucumber.api.CucumberOptions;
import cucumber.api.junit.Cucumber;
import org.junit.runner.RunWith;
/**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a blank new line between imports and a comment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поправь, если не лень.

import cucumber.api.junit.Cucumber;
import org.junit.runner.RunWith;
/**
* @author Anna Osipova <qaosipova@gmail.com>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recommend to specify email here. Also why you're using one email for authoring comments and another one here?

import ru.mystamps.web.Url;

import static org.junit.Assert.assertEquals;
/**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a blank new line between imports and a comment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все-таки хорошо бы исправить.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ок

Given as a user
When I add series to my collection
Then I am on the page with my collection
And I see that this series have been added to the collection
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to replace have been by has been

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok


import static org.junit.Assert.assertEquals;
/**
* @author Anna Osipova <qaosipova@gmail.com>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove e-mail from this tag and leave just a name/surname.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@@ -0,0 +1,8 @@
Feature: User opens series info page, he should see a button for adding series to collection.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rewrite it to User has a collection of stamps. He can add series of stamps to a collection.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

pom.xml Outdated
@@ -506,27 +527,29 @@
<selectizejs.version>0.12.3</selectizejs.version>

<!-- Redefine default value from spring-boot-dependencies (https://github.com/spring-projects/spring-boot/blob/v1.4.6.RELEASE/spring-boot-dependencies/pom.xml) -->
<selenium.version>2.53.1</selenium.version>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this line should be here because we need it.

pom.xml Outdated

<!-- Redefine default value from spring-boot-dependencies (https://github.com/spring-projects/spring-boot/blob/v1.4.6.RELEASE/spring-boot-dependencies/pom.xml) -->
<servlet-api.version>3.1.0</servlet-api.version>

<skipUnitTests>false</skipUnitTests>

<!-- Redefine default value from spring-boot-dependencies (https://github.com/spring-projects/spring-boot/blob/v1.4.6.RELEASE/spring-boot-dependencies/pom.xml) -->
<slf4j.version>1.7.25</slf4j.version>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this? It should be here.

pom.xml Outdated
<start-class>ru.mystamps.web.support.spring.boot.ApplicationBootstrap</start-class>

<subethasmtp.version>3.1.7</subethasmtp.version>
<surefire.plugin.version>2.19.1</surefire.plugin.version>
<testng.version>6.8.8</testng.version>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

pom.xml Outdated

<!-- Redefine default value from spring-boot-dependencies (https://github.com/spring-projects/spring-boot/blob/v1.4.6.RELEASE/spring-boot-dependencies/pom.xml) -->
<spock.version>1.0-groovy-2.0</spock.version>

<!-- Define default value for spring-boot-starter-parent (https://github.com/spring-projects/spring-boot/blob/v1.4.6.RELEASE/spring-boot-starters/spring-boot-starter-parent/pom.xml) -->

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

pom.xml Outdated
<sortpom.plugin.version>2.5.0</sortpom.plugin.version>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@mystamps-bot
Copy link

mystamps-bot commented Jul 13, 2017

1 Warning
⚠️ danger check: branch #46_cucumber_ganna does not comply with our best practices. Branch name should use the following scheme: ghXXX_meaningful-name where XXX is an issue number. Next time, please, use this scheme :)

Generated by 🚫 Danger

pom.xml Outdated

<subethasmtp.version>3.1.7</subethasmtp.version>
<surefire.plugin.version>2.19.1</surefire.plugin.version>
<testng.version>6.8.8</testng.version>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошо бы удалить эту лишнюю строку.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ок

pom.xml Outdated
<!-- Define default value for spring-boot-starter-parent (https://github.com/spring-projects/spring-boot/blob/v1.4.7.RELEASE/spring-boot-starters/spring-boot-starter-parent/pom.xml) -->
<start-class>ru.mystamps.web.support.spring.boot.ApplicationBootstrap</start-class>

<start-class>ru.mystamps.web.support.spring.boot.ApplicationBootstrap</start-class>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А тут почему съехало оформление? Надо вернуть обратно.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ок

Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Что нужно еще сделать, чтобы этот pull request был смерджен:

  • (обязательно) исправить все ошибки от бота. См. его комментарий: Add integration test for adding series to user's collection #525 (comment)
  • (обязательно) объединить все коммиты в один
  • (очень желательно) исправить мелкие просьбы в комментариях о пробельных изменениях

Аня, осталось совсем чуть-чуть!

@php-coder
Copy link
Owner

Дай знать, если нужна моя помощь!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.84% when pulling f17132e on Goblic:#46_cucumber_ganna into 80b8ef1 on php-coder:master.

@php-coder
Copy link
Owner

Merged in f72c87d commit.

@php-coder
Copy link
Owner

Congratulations on your first commit! 👍 I've added you to our rating: https://github.com/php-coder/mystamps/wiki/team-members#closed-at-least-one-ticket :)

Now, I suggest to follow these steps to perform some cleanup: https://github.com/php-coder/mystamps/wiki/after_merge_steps#remove-merged-branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants