Integration with beberlei/assert library

[pdaw]

No description provided.

[lisachenko]

Could you please describe, why do you need to store an invocation object in the private property?

[pdaw]

I created private property to have access to MethodInvocation instance in ContractCheckerAspect::170 line. I don't want to create new parameter in isContractSatisfied method for this (it would be 5th parameter).

Why do we throw exception here? If we return false instead of raising exception, then we lose previous exception (for example - assertion exception) details.

[lisachenko]

I think that private property here can be incorrect for recursive calls of methods, etc, this adds some extra overhead for assigning the value to the property for each method call, maybe it will be better to rewrite code as following:

• rename isContractSatisfied to ensureContractSatisfied that will throw simple DomainException if check was failed (bool false)
• change all ifs in advice's body to try...catch construction that rethrow a ContractViolation exception
• all exceptions now will be in one place, no need for property and extra argument

[pdaw]

I like it, ok

[lisachenko]

Thanks, after that change I'll merge this PR 👍

[lisachenko]

Merged, thanks!