Skip to content

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Oct 9, 2021

  • do not run on push expect when branch is master to prevent double runs in PRs
  • run CI automatically daily

@mfn
Copy link

mfn commented Oct 12, 2021

drop workflow_dispatch as it has no effect here (?)

IMHO that's not true: it just means a user with appropriate permission has the button to run the workflow: otherwise this button isn't available. That's useful to quickly re-run it as a maintainer.

@simPod
Copy link
Contributor Author

simPod commented Oct 12, 2021

@mfn can you point me to what button do you mean? I have this available without need for workflow_dispatch

image

@enumag
Copy link

enumag commented Oct 12, 2021

@simPod It's for this. It appears in the Actions panel if you have workflow_dispatch and the necessary privileges.

image

- do not run on push expect when branch is master to prevent double runs in PRs
- run CI automatically daily
@simPod
Copy link
Contributor Author

simPod commented Oct 12, 2021

Thanks, I've adapted the PR

@rtheunissen rtheunissen merged commit 28206ff into php-ds:master Oct 18, 2021
@simPod simPod deleted the ci-push branch October 19, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants