Allow passing null
as $length
to slice()
methods
#197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
slice()
methods don't work if the value of$length
isnull
, eg:This is inconsistent with how
array_slice()
, and by extension the polyfill work, which treatnull
the same as when no argument is passed: https://3v4l.org/rqsnF . It also makes using a variable harder, eg:This PR proposes allowing passing
null
as the length and treating it the same as when the argument isn't passed.Tests: php-ds/tests#23