Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible Composer PHP requirement in packages since 0.10.24 #1367

Open
lernhart opened this issue Dec 12, 2024 · 2 comments
Open

Incompatible Composer PHP requirement in packages since 0.10.24 #1367

lernhart opened this issue Dec 12, 2024 · 2 comments

Comments

@lernhart
Copy link

It seems that support for PHP 7.4 was intentionally dropped in the latest 0.10.24 release. The base composer.json of the repo has been updated to reflect that properly.
However, the composer.json files in the affected packages still list PHP 7.4 as a valid alternative to PHP 8.0, leading to compatibility issues.

In the following example, running the affected enqueue/enqueue package on PHP 7.4 produces errors like the following, as trailing constructor commas were introduced to the enqueu package:

#message: "syntax error, unexpected ')', expecting variable (T_VARIABLE)"
#code: 0 
#file: "./vendor/enqueue/enqueue/Symfony/Consumption/ConfigurableConsumeCommand.php" 
#line: 50

Not sure, how packages are relesed through this monorepo, but a valid fix should be to update the packages' composer.json's to only allow >=PHP8.1?

@Steveb-p
Copy link
Contributor

If there are any composer.json's that are missing the PHP dependency change, then we should definitely update those. Feel free to make the change and submit the PR if you have spare time for it.

As for the previous versions, it's very hard to fix a mistake like this. We could in theory add conflict declarations in against the offending packages and release a new version of 0.10 too, which would reduce the impact. But we can't really remove the package versions containing invalid declarations.

@lernhart
Copy link
Author

@Steveb-p created a PR. Simply bumped the composer versions in there. CI Actions need approval to run, I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants