Skip to content

Symfony 2.8 compatability issue #158

@jenkoian

Description

@jenkoian

Symfony 2.8 doesn't support a maxDepth on profiler_dump() so the profiler fails on Symfony 2.8 (the max depth got added in 3.2 https://github.com/symfony/symfony/blob/3.2/src/Symfony/Bundle/WebProfilerBundle/Twig/WebProfilerExtension.php#L82). We call this from here btw.

So think we either need to omit the max depth option for now, or remove 2.8 support (https://github.com/php-enqueue/enqueue-bundle/blob/master/composer.json#L15). Happy to submit a PR if you let me know which approach you'd prefer.

Personally I think it'd be a shame to lose 2.8 support over such a minor thing so would opt for either removing the max depth option or if there is some way of detecting symfony version from twig switching the function call to include it conditionally.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions