[dbal] message delay does not work properly

[rolandbrecht]

Let's assume we have a message like

<?php

use Enqueue\Client\Message;

$message = new Message();
$message->setDelay(60); // seconds

/** @var \Enqueue\Client\ProducerInterface $producer */
$producer->sendEvent('aTopic', `$message);

Based on the documentation, the delay is in seconds.

In DbalProducer.php you act on the assumption, that you are not working with seconds, divide them with 1000 and making it all useless.

$delay = $message->getDeliveryDelay();
if ($delay) {
	[...]
    $dbalMessage['delayed_until'] = time() + (int) $delay / 1000;
}

If you need a delay of 1 day (86400s), you'll only get 1 minute and 26 seconds

[makasim]

The Enqueue Client delay is in seconds, a transport delay must be in milliseconds.

We should multiply by 1000 here https://github.com/php-enqueue/enqueue-dev/blob/master/pkg/dbal/Client/DbalDriver.php#L74. That's a bug.

[makasim]

and not sure we should do $dbalMessage['delayed_until'] = time() + (int) $delay / 1000; in producer.

The DBAL transport should deal with milliseconds everywhere, and store it to db too.

The bugfix could be accepted on 0.9 branch.

[rolandbrecht]

dbal table specs are delayed_until int(11).
Remember this, if you switch to microseconds. In the mean time I'll set the message delay to s * 1000 to get this work