We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
During testing of #648 configuration, I got an different issue with the usage of ServerException.
I.e. in enqueue/redis/RedisProducer.php:70 you have the following code:
catch (PRedisServerException $e) { throw new ServerException('lpush command has failed', null, $e); }
In case of an exception I'm getting:
[Symfony\Component\Debug\Exception\FatalThrowableError] Wrong parameters for Enqueue\Redis\ServerException([string $message [, long $code [, Throwable $previous = NULL]]])
Which is because of the null parameter. ServerException is a subclass of \Exception and the __construct() is defined as: (see http://php.net/manual/de/class.exception.php )
public __construct ([ string $message = "" [, int $code = 0 [, Throwable $previous = NULL ]]] )
null is not int, so you'll need to pass 0 in your exception calls.
For reference:
$ php -v PHP 7.1.19-1+ubuntu16.04.1+deb.sury.org+1 (cli) (built: Jul 9 2018 13:12:24) ( NTS )
The text was updated successfully, but these errors were encountered:
d999549
[redis] Fix ServerException. Code should be int, not null
6294639
fixes php-enqueue/enqueue-dev#650
No branches or pull requests
During testing of #648 configuration, I got an different issue with the usage of ServerException.
I.e. in enqueue/redis/RedisProducer.php:70 you have the following code:
In case of an exception I'm getting:
Which is because of the null parameter. ServerException is a subclass of \Exception and the __construct() is defined as:
(see http://php.net/manual/de/class.exception.php )
null is not int, so you'll need to pass 0 in your exception calls.
For reference:
The text was updated successfully, but these errors were encountered: