Skip to content

[dbal] message is not added to the queue #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
otzy opened this issue Jan 18, 2019 · 3 comments
Closed

[dbal] message is not added to the queue #731

otzy opened this issue Jan 18, 2019 · 3 comments

Comments

@otzy
Copy link
Contributor

otzy commented Jan 18, 2019

I use dbal package 0.9.6 with mysql.
producer->send() does not add a record to the queue.

$this->context->getDbalConnection()->insert() in DbalProducer.php:118 returns 0 but no any exception thrown.

But if I comment out the third parameter with types, the message is added successfully.
The problem seems to be in the parameter 'redelivered' => Type::BOOLEAN,
When it's changed to 'redelivered' => Type::SMALLINT, everything works

@otzy
Copy link
Contributor Author

otzy commented Jan 18, 2019

I think it's also worth to check that insert() returned 1 and throw an exception otherwise.

And btw. it will be nice if you inherited all your exceptions from RuntimeException. Most of them I think caused by the wrong usage of library and there is no need to catch them in the app

@makasim
Copy link
Member

makasim commented Jan 18, 2019

that strange since there are some functional tests which pass.

Would you like to submit a PR?

@makasim makasim changed the title message is not added to the queue [dbal] message is not added to the queue Jan 19, 2019
@otzy
Copy link
Contributor Author

otzy commented Jan 21, 2019

I created PR. Not sure if the destination is correct though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants