Skip to content

Upgrade php-amqplib to v3.0 #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Upgrade php-amqplib to v3.0 #1146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pkg/amqp-lib/Tests/AmqpConsumerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@ public function testShouldImplementConsumerInterface()

public function testCouldBeConstructedWithContextAndQueueAsArguments()
{
new AmqpConsumer(
$this->createContextMock(),
new AmqpQueue('aName')
self::assertInstanceOf(AmqpConsumer::class,
new AmqpConsumer(
$this->createContextMock(),
new AmqpQueue('aName')
)
);
}

Expand Down
5 changes: 4 additions & 1 deletion pkg/amqp-lib/Tests/AmqpProducerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ class AmqpProducerTest extends TestCase

public function testCouldBeConstructedWithRequiredArguments()
{
new AmqpProducer($this->createAmqpChannelMock(), $this->createContextMock());
self::assertInstanceOf(
AmqpProducer::class,
new AmqpProducer($this->createAmqpChannelMock(), $this->createContextMock())
);
}

public function testShouldImplementProducerInterface()
Expand Down
5 changes: 4 additions & 1 deletion pkg/amqp-lib/Tests/AmqpSubscriptionConsumerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ public function testShouldImplementSubscriptionConsumerInterface()

public function testCouldBeConstructedWithAmqpContextAndHeartbeatOnTickAsArguments()
{
new AmqpSubscriptionConsumer($this->createAmqpContextMock(), $heartbeatOnTick = true);
self::assertInstanceOf(
AmqpSubscriptionConsumer::class,
new AmqpSubscriptionConsumer($this->createAmqpContextMock(), $heartbeatOnTick = true)
);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion pkg/amqp-lib/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"license": "MIT",
"require": {
"php": "^7.3|^8.0",
"php-amqplib/php-amqplib": "^2.12.1",
"php-amqplib/php-amqplib": "^3.0",
"queue-interop/amqp-interop": "^0.8.2",
"queue-interop/queue-interop": "^0.8",
"enqueue/amqp-tools": "^0.10"
Expand Down