Try to change doctrine/orm version for supporting 2.8 (PHP 8 support). #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested it ? |
|
Need to setup a work environment because it needs env var to work with your testing config. |
|
You should not require this repo directly. fork read only package, apply your changes and require it in composer. Once done, backport changes to this repo. |
|
My fork runs on my app (just installing and clear the cache). |
|
Good, thanks |
deguif
reviewed
Mar 26, 2021
| @@ -10,7 +10,7 @@ | |||
| "enqueue/enqueue": "^0.10", | |||
| "enqueue/null": "^0.10", | |||
| "queue-interop/queue-interop": "^0.8", | |||
| "doctrine/orm": "~2.7.4", | |||
| "doctrine/orm": "~2.7.4 | ^2.8", | |||
There was a problem hiding this comment.
Can not this be simplified to "^2.7.4" only?
|
fixes #1151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to use doctrine/orm 2.8 with job queue, this is the last step to php 8 support.