[amqp-ext] Passing null to parameter is deprecated. #1275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not change the line reported by the code style check in this PR. I fixed that in a separate PR #1276 |
|
Nice change for 8.1 compatibility, can we have this merged please @makasim |
Indeed, once all tests are green |
The failures seem to be unrelated to my changes (403 from AWS). Can you please take a look? Maybe they need to be rerun? |
|
Sorry, I am not going to look into it. I don't use the library nor write in PHP. I can review and merge when everything is green, and release it. |
Fixes deprecation notice "Deprecated: AMQPQueue::consume(): Passing null to parameter #3 ($consumer_tag) of type string is deprecated in"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deprecation notice
Deprecated: AMQPQueue::consume(): Passing null to parameter #3 ($consumer_tag) of type string is deprecated in