Skip to content

RedisConnectionFactory accept an exist redis object #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

RedisConnectionFactory accept an exist redis object #346

wants to merge 1 commit into from

Conversation

@charleslxh
Copy link

makasim
makasim reviewed Jan 24, 2018
View reviewed changes
pkg/redis/RedisConnectionFactory.php
/**
* @param $redis
*/
public function setRedis($redis)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not in favor of a setter. The RedisConnectionFactory constructor should handle all this.

@makasim makasim mentioned this pull request Feb 15, 2018
Merged
@makasim
Copy link
Member

makasim commented Feb 15, 2018

close in favor #372

@makasim makasim closed this Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@makasim makasim makasim left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charleslxh @makasim @charleslxh2