-
Notifications
You must be signed in to change notification settings - Fork 440
allow tls as scheme in DSN string for predis library #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tls is to broad, I’d suggest changing it to scheme |
Agree |
OK @makasim, I changed it to Please accept the MR! |
Could you please add some tests to RedisConnectionFactoryConfigTest? |
Hi @makasim, I added tests to RedisConnectionFactoryConfigTest as you requested! |
makasim
reviewed
Sep 1, 2018
Hi @makasim were you able to finish your review? |
Thanks for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Predis allows connecting to TLS encrypted endpoints by using scheme=tls which is not allowed by current enqueue library. This is needed to connect to major cloud provider's redis services. I added the posibility to specify tls:// endpoints in DSN string for each configuration.
See predis docs for more info on TLS: https://github.com/nrk/predis
My DSN string looks as following: