[redis][poc] Add delay strategy #560
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the bottom of the queue
makasim
commented
Oct 16, 2018
| @@ -0,0 +1,26 @@ | |||
| <?php | |||
|
|
|||
| namespace Enqueue\RedisTools; | |||
There was a problem hiding this comment.
I dont think we need redis tool for now, the code could be in Enqueue\Redis
|
|
||
| $targetTimestamp = time() + $delayMsec / 1000; | ||
|
|
||
| $context->getRedis()->zadd('enqueue:'.$dest->getTopicName().':delayed', $targetTimestamp, $targetTimestamp); |
There was a problem hiding this comment.
the third argument should be a serialized message.
There was a problem hiding this comment.
and if we do so we can stop on this. no need to send a message to enqueue:{topic}:delayed:{timestamp} collection.
| use Interop\Queue\PsrConsumer; | ||
| use Interop\Queue\PsrMessage; | ||
|
|
||
| class RedisZSetDelayConsumer implements PsrConsumer |
There was a problem hiding this comment.
the code could be moved to RedisZSetDelayStrategy.
| @@ -46,15 +65,21 @@ public function setDeliveryDelay($deliveryDelay) | |||
| return; | |||
| } | |||
|
|
|||
| throw new \LogicException('Not implemented'); | |||
| if (null === $this->delayStrategy) { | |||
There was a problem hiding this comment.
null === $this->delayStrategy && null !== $deliveryDelay
|
close in favor of #585 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #553