Add php 7.4 to test matrix #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't PHP 7.4 now officially out? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Unstale |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Unstale 🤦♂ |
|
I've re-run the tests. Apparently some tests are failing on PHP 7.4 specifically: There were 2 errors:
1) Enqueue\Pheanstalk\Tests\PheanstalkConsumerTest::testShouldReceiveFromQueueAndReturnMessageIfMessageInQueue
Trying to access array offset on value of type null
/home/travis/build/php-enqueue/enqueue-dev/pkg/pheanstalk/PheanstalkConsumer.php:114
/home/travis/build/php-enqueue/enqueue-dev/pkg/pheanstalk/PheanstalkConsumer.php:53
/home/travis/build/php-enqueue/enqueue-dev/pkg/pheanstalk/Tests/PheanstalkConsumerTest.php:71
2) Enqueue\Pheanstalk\Tests\PheanstalkConsumerTest::testShouldReceiveNoWaitFromQueueAndReturnMessageIfMessageInQueue
Trying to access array offset on value of type null
/home/travis/build/php-enqueue/enqueue-dev/pkg/pheanstalk/PheanstalkConsumer.php:114
/home/travis/build/php-enqueue/enqueue-dev/pkg/pheanstalk/PheanstalkConsumer.php:66
/home/travis/build/php-enqueue/enqueue-dev/pkg/pheanstalk/Tests/PheanstalkConsumerTest.php:113We'll have to fix them before merging. |
|
@Steveb-p all test green! |
|
It contains some unrelated changes. I am gonna merge this for now but please open separate PRs in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.