Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made that the Remove and Update commands in the Cloud context can be used with several satellites in a single file #152

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sebprt
Copy link
Contributor

@sebprt sebprt commented Jan 22, 2024

No description provided.

…used with several satellites in a single file
@sebprt sebprt added the GTM label Jan 22, 2024
@sebprt sebprt requested a review from gplanchat January 22, 2024 16:00
@sebprt sebprt self-assigned this Jan 22, 2024
@sebprt sebprt linked an issue Jan 22, 2024 that may be closed by this pull request
Copy link
Contributor

@gplanchat gplanchat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que tu peux ajouter des tests PHPunit ?

);

$output = $commandTester->getDisplay();
$this->assertStringContainsString('Résultat attendu', $output);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne comprend pas ce que ce test fait.

Est-ce que tu peux plutôt :

  • utiliser la commande en direct, pas besoin de passer par l'application complète
  • Injecter un client HTTP de mock et vérifiee que les requêtes soit conforme à tes attentes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

[Cloud] Utiliser les commandes avec plusieurs satellites
2 participants