Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming resetSequence() to resetAutoIncrementPK() and getNextAutoIncrementValue() to getNextAutoIncrementPKValue() in Schema::class. #102

Merged
merged 5 commits into from
Sep 22, 2024

Conversation

terabytesoftw
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #57

…extAutoIncrementValue()` to `getNextAutoIncrementPKValue()` in `Schema::class`.
@terabytesoftw terabytesoftw added the Severity: BC breaking Either breaks backwards compatibility or fixed previously made breakage label Sep 21, 2024
@terabytesoftw terabytesoftw added this to the 1.0.0 milestone Sep 21, 2024
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.61%. Comparing base (8f2aaac) to head (2e8d159).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #102      +/-   ##
============================================
- Coverage     66.64%   66.61%   -0.03%     
+ Complexity    11183    11171      -12     
============================================
  Files           433      433              
  Lines         36444    36414      -30     
============================================
- Hits          24289    24259      -30     
  Misses        12155    12155              
Flag Coverage Δ
17.35% <63.63%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw merged commit e7670af into main Sep 22, 2024
111 of 112 checks passed
@terabytesoftw terabytesoftw deleted the better-naming branch September 22, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity: BC breaking Either breaks backwards compatibility or fixed previously made breakage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant