Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adpot PSR-16 simple cache in UrlManager::class. #46

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

terabytesoftw
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #45

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 71.11111% with 13 lines in your changes missing coverage. Please review.

Project coverage is 66.50%. Comparing base (df4ba3f) to head (25589c3).

Files Patch % Lines
src/web/UrlManager.php 64.86% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #46      +/-   ##
============================================
- Coverage     66.51%   66.50%   -0.01%     
- Complexity    11234    11241       +7     
============================================
  Files           424      425       +1     
  Lines         36346    36369      +23     
============================================
+ Hits          24175    24189      +14     
- Misses        12171    12180       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw added the Improvement Nueva función o petición label Jul 17, 2024
@terabytesoftw terabytesoftw added this to the 1.0.0 milestone Jul 17, 2024
@terabytesoftw terabytesoftw merged commit 8e85e5d into main Jul 17, 2024
114 checks passed
@terabytesoftw terabytesoftw deleted the psr-16-1 branch July 17, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Nueva función o petición
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant