Skip to content

raise minimum php and symfony versions #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dbu opened this issue Jun 11, 2024 · 2 comments
Closed

raise minimum php and symfony versions #458

dbu opened this issue Jun 11, 2024 · 2 comments
Milestone
2.0.0

Comments

@dbu
Copy link
Collaborator

dbu commented Jun 11, 2024

for version 2, we should raise the PHP version.

Lets do ^8.1 and only allow Symfony : ^6.4|^7.1.

Check code for BC things for old symfony versions.
@dbu dbu added this to the 2.0.0 milestone Jun 11, 2024
@dbu dbu mentioned this issue Jun 11, 2024
Merged
3 tasks
andrew-demb pushed a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
📦 [php-http#458] Update min Symfony version to ^6.4 || ^7.1
a286839
andrew-demb pushed a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
⬆️ [php-http#458] Update min PHP version to 8.1
1464c9a
andrew-demb pushed a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
📦 [php-http#458] Introduce property types, use PHP 8.1 features (CPP,…
2962292 
… short arrow function, readonly properties, etc)
andrew-demb pushed a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
📦 [php-http#458] Update min Symfony version to ^6.4 || ^7.1
9d14f44
andrew-demb pushed a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
⬆️ [php-http#458] Update min PHP version to 8.1
fd87417
andrew-demb pushed a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
📦 [php-http#458] Introduce property types, use PHP 8.1 features (CPP,…
9e1c1b6 
… short arrow function, readonly properties, etc)
andrew-demb added a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
@andrew-demb
📦 [php-http#458] Update min Symfony version to ^6.4 || ^7.1
d59f6e9
andrew-demb added a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
@andrew-demb
⬆️ [php-http#458] Update min PHP version to 8.1
ee512f2
andrew-demb added a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
@andrew-demb
📦 [php-http#458] Introduce property types, use PHP 8.1 features (CPP,…
d958ead 
… short arrow function, readonly properties, etc)
@andrew-demb andrew-demb mentioned this issue Aug 25, 2024
Merged
2 tasks
andrew-demb added a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
@andrew-demb
📦 [php-http#458] Switch to php-cs-fixer 3.26 and run it
28f3beb
andrew-demb added a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
@andrew-demb
📦 [php-http#458] Switch to php-cs-fixer-ga 3.26 and run it
1c334e2
andrew-demb added a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
@andrew-demb
⬆️ [php-http#458] Update min PHP version to 8.1
60d7869
andrew-demb added a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
@andrew-demb
📦 [php-http#458] Update min Symfony version to ^6.4 || ^7.1
3c37a86
andrew-demb added a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
@andrew-demb
📦 [php-http#458] Introduce property types, use PHP 8.1 features (CPP,…
7d82664 
… short arrow function, readonly properties, etc)
andrew-demb added a commit to andrew-demb/HttplugBundle that referenced this issue Aug 25, 2024
@andrew-demb
📦 [php-http#458] Switch to php-cs-fixer-ga 3.26 and run it
6548642
@andrew-demb
Copy link
Contributor

I opened a PR to resolve this #463

dbu pushed a commit that referenced this issue Sep 2, 2024
@andrew-demb
[2.x] Min PHP version 8.1, Symfony 6.4 / 7.1+ (#463)
c6c246f 
* ⬆️ [#458] Update min PHP version to 8.1
* 📦 Add typehint to parameter in private method
* 📦 [#458] Update min Symfony version to `^6.4 || ^7.1`
* 📦 Hint about always non-null return type
* 📦 Avoid deprecated DI extension class
* 📦 Fix property type in phpdoc
* 📦 Avoid invalid argument - cast possible float to the integer
* 📦 [#458] Introduce property types, use PHP 8.1 features (CPP, short arrow function, readonly properties, etc)
* 📦 [#458] Switch to `php-cs-fixer-ga` 3.26 and run it
* 📦 Require phpunit 9 because `simple-phpunit` is not compatible with phpunit 10 and `matthiasnoback/symfony-config-test` triggers installation of phpunit 10
* 💄 Multiline constructor parameters
* 📦 Safe property types - property can be uninitialized. Explicitly mention possible return null
* 📦 Use native union type for parameter
* 📦 Enforce installing `matthiasnoback/symfony-config-test` to fix CI for lowest deps
@dbu
Copy link
Collaborator Author

dbu commented Sep 2, 2024

done in #463, thanks a lot @andrew-demb !

@dbu dbu closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@dbu @andrew-demb