Skip to content

Added psr/cache:^3.0 dependency #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Added psr/cache:^3.0 dependency #78

merged 1 commit into from
Jan 18, 2022

Conversation

yoshz
Copy link
Contributor

@yoshz yoshz commented Jan 9, 2022

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
Documentation N/A
License MIT

What's in this PR?

Allow the usage of psr/cache:3.0.

Why?

Version psr/cache:3.0 is already released a while ago and should be compatible with this plugin but the current composer.json configuration doesn't allow you to use this.
In my use case composer complains about a conflict while installing the cache-plugin because symfony/cache:6.0 requires psr/cache:3.0.

@GrahamCampbell
Copy link
Contributor

I don't think this will work without changes to the code.

@GrahamCampbell
Copy link
Contributor

In my use case composer complains about a conflict while installing the cache-plugin because symfony/cache:6.0 requires psr/cache:3.0.

Add this cache-plugin by hand to your composer.json and run composer update. It should install.

@dbu
Copy link
Contributor

dbu commented Jan 10, 2022

thanks @yoshz for this. seems good to me, and the tests agree.

but lets give graham time to react:

I don't think this will work without changes to the code.

https://github.com/php-http/cache-plugin/runs/4758238019?check_suite_focus=true installed psr/cache 3.0.0 and is green. either it works, or the tests do not trigger the problem.

looking at php-fig/cache@2.0.0...3.0.0, i think the only difference is that the psr interfaces now have return types. we don't implement the interfaces in this package but only consume it, so it should be fine. what do you think shoudl be a problem, @GrahamCampbell

@yoshz
Copy link
Contributor Author

yoshz commented Jan 10, 2022

I also checked the changelog and the only difference is indeed the return types. So should be BC and I already tested it with my project.

@Nyholm
Copy link
Member

Nyholm commented Jan 18, 2022

I was sure this would work.

As a consumer of psr/cache you can depend on any version. The libraries that implement the interfaces are forced to do a new major version.

Yes. I agree that this is just busy work that gives zero real benefit. But that is what the Fig decided to do.

Im 👍🏽

@dbu dbu merged commit aed86a8 into php-http:master Jan 18, 2022
@dbu
Copy link
Contributor

dbu commented Jan 18, 2022

@Nyholm
Copy link
Member

Nyholm commented Jan 18, 2022

Thank you @yoshz and @dbu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants