Functional test to ensure no issue with plugins in sync nor async requests #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Jan 2, 2019
There was a problem hiding this comment.
this looks like a useful functional test to make sure we never mess up with either sync or async client.
@sagikazarmark is it reasonable to write such a functional test in phpspec, or does it make more sense to use phpunit for this? the point to me is that we don't mock but use actual clients and plugins.
|
btw, its not highlighting a bug anymore, lets change the description |
dbu
changed the title
dbu
changed the title
|
To be honest, I think we should stop using phpspec. PHPSpec is great, but it requires too much hacks and results in absolutely not expressive tests in our case. |
gmponos
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
I found a bug. The bug is present all these are true:
return $first($request)->wait()HOWEVER, using
return $first($request)->wait()does not make any sense...I got the idea from #103 but after writing this PR and #103 (comment) I discovered that there is no bug and one should never do
return $first($request)->wait().Im not sure we want to merge this test or not. I kind of like the code so I did not want to throw it away =)