Skip to content

Add a note about immutability and sendResponses #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joelwurtz opened this issue Oct 24, 2015 · 2 comments
Closed

Add a note about immutability and sendResponses #11

joelwurtz opened this issue Oct 24, 2015 · 2 comments

Comments

@joelwurtz
Copy link
Member

The sendResponses method return a batch result. User can retrieve response and/or exception with the getResponseFor / getExceptionFor.

If the request is updated in the sendRequests method and this transformed request is used to index the response / exception in the batch result user wil never retrieve the result.

IMO we should add a line for implementation client saying that they must used the original request to index the response / exception.

@dbu
Copy link
Contributor

dbu commented Oct 29, 2015

luckily these problems are obsolete now that we dropped the BatchRequest, right? with async this should work better, right? do we need to do something here or close it?

@sagikazarmark
Copy link
Member

Agree, we can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants