documentation from nicolas grekas for discovery #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,54 @@ Discovery is simply a convenience wrapper to statically access clients and facto | |||
| Dependency Injection is not an option. Discovery is particularly useful in libraries that want to | |||
| offer zero-configuration services relying on the virtual packages. | |||
|
|
|||
| Using discovery in a shared library | |||
| ------------------------------------- | |||
| $ composer require --dev symfony/http-client | ||
| $ composer require --dev nyholm/psr7 | ||
|
|
||
| Then, you can disable the Composer plugin provided by``php-http/discovery`` |
There was a problem hiding this comment.
missing space after "by"
|
thanks for the review. i was too quick merging this 🙈 fixed them directly in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge #304 with the changes i did in #305