Fix phpunit tests #10
Conversation
Add the `composer test` command as mentioned in the readme file. And as phpunit's prophesize method is deprecated from version 9 on and will be removed in phpunit 10, use the trait from phpspec/prophecy-phpunit instead as recommended.
phpspec/prophecy-phpunit v2 which contains the needed trait isn't available for PHP 7.2, so bump the version requirement to 7.3. Also use composer test instead of phpunit directly in the ci config and remove running the tests on version 7.2. Finally also remove --diff-format to get cs running again.
|
@dbu I just pushed:
Also added a changelog entry. Wasn't sure if you want to actually tag it already or maybe just merge it and leave it in the changelog as "unreleased" until the next change actually relevant for users? |
|
i changed the changelog to "unreleased", i don't think we need a release as no functional changes happened. it seems the cs fixer has not been run in a long time... shall i take over or are you okay to also rename (and if necessary adjust) the cs-fixer configuration file? |
|
Perfectly fine with you taking over, thx 🙂👌🏻 |
New php cs fixer config file name.
|
@dbu The output of the github action for the cs fixer said: |
CHANGELOG.md
Outdated
| ### Fixed | ||
| - Add missing `composer test` command and use it in CI | ||
| - Fix deprecated usage of prophesize in phpunit tests | ||
| - Drop support for PHP version 7.2 |
There was a problem hiding this comment.
| - Drop support for PHP version 7.2 | |
| - Drop support for PHP version 7.2 |
please move this point up above the ### Fixed heading - it is not something we fixed, just changed ;-)
|
thanks for picking this up again. i did not yet find time to look into it. afaik the format of the cs fixer configuration also changed. an example of the new format would be https://github.com/FriendsOfSymfony/FOSHttpCache/blob/master/.php-cs-fixer.dist.php |
|
I just changed the changelog and tried to fix the cs fixer config file 🤞🏻 |
setFinder() isn't static.
|
🥳😅 |
What's in this PR?
I wanted to make a pull request for another thing, that I'll prepare next. I checked out the project and had a look at the readme where it says that you can run
composer test, but the command didn't exist, so I added the"test": "@php vendor/bin/phpunit"script. Also when running tests I saw the warning:Which relates to sebastianbergmann/phpunit#4141, so I did as recommended require phpspec/prophecy-phpunit and use the trait from there to fix the warning.
Why?
composer testcommand/script was missing.Checklist