Deprecate Http\Client\HttpClient and allow psr/http-message v2 #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Apr 11, 2023
|
Sibling PR at php-http/message-factory#42 |
dbu
reviewed
Apr 11, 2023
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Apr 17, 2023
…(nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [ErrorHandler] Don't throw deprecations for HttplugClient | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #50035 | License | MIT | Doc PR | - Follows php-http/httplug#171 and #47832 Required to make the CI green again. Commits ------- bafb237 [ErrorHandler] Don't throw deprecations for HttplugClient
This was referenced Apr 26, 2023
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Apr 26, 2023
…s deprecated (nicolas-grekas) This PR was merged into the 6.3 branch. Discussion ---------- [HttpClient] Add PSR-18 to HttplugClient since HTTPlug is deprecated | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Relates to php-http/httplug#171 Commits ------- ab9cefc [HttpClient] Add PSR-18 to HttplugClient since HTTPlug is deprecated
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
May 2, 2023
… (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [ErrorHandler] Skip Httplug deprecations for HttplugClient | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follows #50036 and php-http/httplug#171 Commits ------- 159bf0b [ErrorHandler] Skip Httplug deprecations for HttplugClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's be more explicit about the move to PSR-18.
I'm not throwing a runtime deprecation notice because that might be too annoying for the existing clients, especially those in the
php-http/*namespace.