-
Notifications
You must be signed in to change notification settings - Fork 39
[RFC] Replace sendRequests with an async approach #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<?php | ||
|
||
namespace Http\Client; | ||
|
||
use Psr\Http\Message\RequestInterface; | ||
|
||
/** | ||
* Sends a PSR-7 Request in an asynchronous way by returning a Promise. | ||
* | ||
* @author Joel Wurtz <joel.wurtz@gmail.com> | ||
*/ | ||
interface HttpAsyncClient | ||
{ | ||
/** | ||
* Sends a PSR-7 request in an asynchronous way. | ||
* | ||
* @param RequestInterface $request | ||
* | ||
* @return Promise | ||
* | ||
* @throws Exception | ||
*/ | ||
public function sendAsyncRequest(RequestInterface $request); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
<?php | ||
|
||
namespace Http\Client; | ||
|
||
/** | ||
* Promise represents a response that may not be available yet, but will be resolved at some point in future. | ||
* It acts like a proxy to the actual response. | ||
* | ||
* @author Joel Wurtz <joel.wurtz@gmail.com> | ||
*/ | ||
interface Promise | ||
{ | ||
/** | ||
* Add behavior for when the promise is resolved or rejected (response will be available, or error happens) | ||
* | ||
* @param callable $onFulfilled Called when a response will be available, it will receive a Psr\Http\Message\RequestInterface object as the first argument | ||
* @param callable $onRejected Called when an error happens, it will receive a Http\Client\Exception object as the first argument | ||
* | ||
* @return Promise Always returns a new promise which is resolved with value of the executed callback (onFulfilled / onRejected) | ||
*/ | ||
public function then(callable $onFulfilled, callable $onRejected); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the callables also receive the request object?