Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Start version 2 with some cleanups #34

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Dec 30, 2018

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Related tickets BC breaking changes from #29
Documentation -
License MIT

What's in this PR?

Some BC breaking changes that clean up the mock client. To be merged when we want to start with version 2.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • no documentation changes needed

TODO

src/Client.php Show resolved Hide resolved
src/Client.php Outdated
@@ -23,7 +22,6 @@
class Client implements HttpClient, HttpAsyncClient
{
use HttpAsyncClientEmulator;
use VersionBridgeClient;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we bump to only version 2 of httplug

@Nyholm
Copy link
Member

Nyholm commented Dec 30, 2018

Why do you want to release a new major version of this client?

@dbu
Copy link
Contributor Author

dbu commented Dec 30, 2018

i don't want to do that now, just wanted to keep the cleanups that we agreed are useful but are BC break. i don't intend to merge this anytime soon.

@dbu dbu added this to the 2.0 milestone Jan 20, 2019
@dbu
Copy link
Contributor Author

dbu commented Jan 27, 2019

as per discussion in #36 i want to merge this soonish. does that change if we want to drop httplug 1 support? the cost of supporting both is low and i think there would be value in keeping that so that libraries can test with both httplug 1 and 2 for a while.

@Taluu
Copy link

Taluu commented Sep 11, 2019

Any update on this PR ? :}

@dbu
Copy link
Contributor Author

dbu commented Sep 12, 2019

i did not find the time to continue on this. if you want to wrap things up, more than happy to review things ;-)

@Taluu
Copy link

Taluu commented Sep 12, 2019

I'll give it a try whenever I get some time (not right now...). Do not wait on me though 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide psr/http-client-implementation in composer.json
3 participants