Skip to content

Add history plugin #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2015
Merged

Add history plugin #18

merged 1 commit into from
Dec 17, 2015

Conversation

joelwurtz
Copy link
Member

No description provided.

@dbu
Copy link
Contributor

dbu commented Dec 17, 2015

do we want to provide an in-memory implementation of the journal in here? or are people supposed to write their own implementation?

@dbu
Copy link
Contributor

dbu commented Dec 17, 2015

nice and short, i like it!

@sagikazarmark
Copy link
Member

Maybe we could provide a Psr3 implementation?

@Nyholm
Copy link
Member

Nyholm commented Dec 17, 2015

Not sure if that is a good idea. If we require a PSR3 implementation, how does this plugin differ from the LoggerPlugin?

@dbu
Copy link
Contributor

dbu commented Dec 17, 2015 via email

@sagikazarmark
Copy link
Member

Okay, makes sense. In that case an in-memory journal would probably make sense. I imagine it could be something like the BatchResponse in utils.

@joelwurtz
Copy link
Member Author

In fact, this is mainly to interface this with some frameworks, or other debug tools.

Don't know if it's useful to provide an implementation ? Use case i have in mind here is to have a class which use this interface and bridge DataCollector from symfony to have request / response / exceptions in the debug toolbar.

@sagikazarmark
Copy link
Member

@joelwurtz cool idea, like that. In fact, I would really need a solution like that RIGHT NOW. 😛

But I also think that it might be useful for testing as @dbu said.

@joelwurtz
Copy link
Member Author

We can merge this as it, and do a in memory implementation later :)

@sagikazarmark
Copy link
Member

Fine by me. Maybe you could add an issue to document this plugin as well.

@joelwurtz
Copy link
Member Author

Yes, need to add an issue for the cache plugin documentation also

joelwurtz added a commit that referenced this pull request Dec 17, 2015
@joelwurtz joelwurtz merged commit 09694c3 into master Dec 17, 2015
@joelwurtz joelwurtz deleted the feature/history-plugin branch December 21, 2015 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants