-
Notifications
You must be signed in to change notification settings - Fork 6
Add history plugin #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
do we want to provide an in-memory implementation of the journal in here? or are people supposed to write their own implementation? |
nice and short, i like it! |
Maybe we could provide a Psr3 implementation? |
Not sure if that is a good idea. If we require a PSR3 implementation, how does this plugin differ from the LoggerPlugin? |
i guess the main idea of history is to do tests or other analysis during
run time. everything else is likely about logging. or about caching maybe.
|
Okay, makes sense. In that case an in-memory journal would probably make sense. I imagine it could be something like the BatchResponse in utils. |
In fact, this is mainly to interface this with some frameworks, or other debug tools. Don't know if it's useful to provide an implementation ? Use case i have in mind here is to have a class which use this interface and bridge DataCollector from symfony to have request / response / exceptions in the debug toolbar. |
@joelwurtz cool idea, like that. In fact, I would really need a solution like that RIGHT NOW. 😛 But I also think that it might be useful for testing as @dbu said. |
We can merge this as it, and do a in memory implementation later :) |
Fine by me. Maybe you could add an issue to document this plugin as well. |
Yes, need to add an issue for the cache plugin documentation also |
No description provided.