-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make compatible with stream interface #72
Conversation
591da43
to
f4b9555
Compare
f4b9555
to
e2d3906
Compare
Can we help to proceed this PR? |
thanks for asking. if you have some time to look if you can reproduce the test failures locally, and ideally can find what causes them, it would help for sure. you could do a merge request against this branch if its a small change, or create a new merge request against 2.x with your changes, whatever is easier for you. |
I cannot get stable responses for the latest version of
As I can see, only when I include header |
This test failures with lowest deps:
Can be fixed either by:
|
@dbu I suggest to do three things:
===================================================================
diff --git a/composer.json b/composer.json
--- a/composer.json (revision 1bb68e85b6be6567cc1ea145f8a2b145d9108cfe)
+++ b/composer.json (date 1718317478552)
@@ -17,7 +17,7 @@
},
"require-dev": {
"friendsofphp/php-cs-fixer": "^3.51",
- "php-http/client-integration-tests": "^3.0",
+ "php-http/client-integration-tests": "^3.1",
"php-http/message": "^1.16",
"php-http/client-common": "^2.7",
"phpunit/phpunit": "^8.5.23 || ~9.5" ===================================================================
diff --git a/tests/SocketClientFeatureTest.php b/tests/SocketClientFeatureTest.php
--- a/tests/SocketClientFeatureTest.php (revision 1bb68e85b6be6567cc1ea145f8a2b145d9108cfe)
+++ b/tests/SocketClientFeatureTest.php (date 1718317770046)
@@ -12,4 +12,29 @@
{
return new SocketHttpClient();
}
+
+ public function testAutoSetContentLength(): void
+ {
+ $this->markTestSkipped('Feature is unsupported');
+ }
+
+ public function testGzip(): void
+ {
+ $this->markTestSkipped('Feature is unsupported');
+ }
+
+ public function testDeflate(): void
+ {
+ $this->markTestSkipped('Feature is unsupported');
+ }
+
+ public function testChunked(): void
+ {
+ $this->markTestSkipped('Feature is unsupported');
+ }
+
+ public function testRedirect(): void
+ {
+ $this->markTestSkipped('Feature is unsupported');
+ }
} |
Here it is #75 |
continued in #75, thanks a lot @andrew-demb |
the remaining failures will be fixed with php-http/client-integration-tests#59