Fix invalid format MIME type definition #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
reviewed
Nov 15, 2022
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
ausi
approved these changes
Nov 15, 2022
|
I have added simple unit test that asserts expected MIME types for a few basic image formats. |
ausi
approved these changes
Nov 15, 2022
|
Nice catch! I noticed you also fixed the file extension for WBMP. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have discovered that $image->show() was setting invalid Content-Type header. "jpg" in case of "jpg" format instead of "image/jpg".
There seems to be an invalid argument order in the constructor call to Imagine\Image\Format.
The constructor signature is:
private function __construct($id, $mimeType, $canonicalFileExtension, $alternativeIDs = array())While callers were clearly setting MIME type into 3. argument instead of second one.