feat: add inline tool definition and chain in chain 🤯 #75
Conversation
chr-hertel
force-pushed
the
feat-service-tools
branch
from
470dbc7 to
a794af9
Compare
| - service: 'llm_chain.chain.research' | ||
| name: 'wikipedia_research' | ||
| description: 'Can research on Wikipedia' | ||
| is_chain: true |
There was a problem hiding this comment.
While thinking about this, do we really need this? We know service is a ChainInterface 🤔
There was a problem hiding this comment.
another thing of writing could be:
- service: 'llm_chain.chain.research'
+ chain: 'llm_chain.chain.research'
name: 'wikipedia_research'
description: 'Can research on Wikipedia'
- is_chain: trueThere was a problem hiding this comment.
but I think I would just remove the is_chain
There was a problem hiding this comment.
i tried to omit that thing, but failed 😢
There was a problem hiding this comment.
but why, don't we know at that time, that the service is an instance of ChainInterface?
There was a problem hiding this comment.
i'm with you on this, but i just don't know how 😆
There was a problem hiding this comment.
Alright then, but I can also set is_chain true and add anything else in service then, but we can communicate that with a clear error I guess
There was a problem hiding this comment.
quite in your face, yes
chr-hertel
force-pushed
the
feat-service-tools
branch
from
a794af9 to
d816e9d
Compare
No description provided.