refactor: centralize json schema generation #212
Conversation
chr-hertel
force-pushed
the
refactor-schema-factory
branch
2 times, most recently
from
c838eb5 to
e6f1b7c
Compare
chr-hertel
force-pushed
the
refactor-schema-factory
branch
3 times, most recently
from
7c98850 to
2e42f1f
Compare
chr-hertel
force-pushed
the
refactor-schema-factory
branch
from
2e42f1f to
5f39ef1
Compare
| @@ -213,17 +213,17 @@ final class MyTool | |||
| * @param int $number The number of an object | |||
| */ | |||
| public function __invoke( | |||
| #[ToolParameter(pattern: '/([a-z0-1]){5}/')] | |||
| #[With(pattern: '/([a-z0-1]){5}/')] | |||
There was a problem hiding this comment.
I propose to use an extra PR for the renaming to #[With]
There was a problem hiding this comment.
Besides that, we can also add an internal map, so that you can only use minimum and maximum with an int for example + we can throw an exception if the properties are not typed, or do we already?
There was a problem hiding this comment.
so just move it first, rename it later you mean?
There was a problem hiding this comment.
I would rename in a first PR, and see how big this PR still is. It gets messy quite fast when moving and renaming things
There was a problem hiding this comment.
Updated my comment, in case you missed it
There was a problem hiding this comment.
Yeah, should think of getting this smaller anyways, true. Refactoring wasn't as successful as hoped for
| use function Symfony\Component\String\u; | ||
|
|
||
| /** | ||
| * @internal |
currently not working with custom types in arrays, see
MathReasoning->Step[]