Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

Allow mongodb/mongodb 2.0 #341

Merged
merged 1 commit into from
Jun 24, 2025
Merged

Allow mongodb/mongodb 2.0 #341

merged 1 commit into from
Jun 24, 2025

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Jun 24, 2025

closes #286
partially reverts #281

@OskarStark OskarStark self-assigned this Jun 24, 2025
@OskarStark OskarStark requested review from chr-hertel and Copilot and removed request for chr-hertel June 24, 2025 14:34
@OskarStark OskarStark changed the title Use mongodb:2.0 Allow mongodb:2.0 Jun 24, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MongoDB driver support by allowing version 2.0 and adjusts the CI pipeline accordingly.

  • Updated the dependency constraint for mongodb/mongodb in require-dev of composer.json to include version 2.0.
  • Removed the conflict block in composer.json that restricted mongodb/mongodb to versions below 1.21.
  • Added a required PHP extension configuration for the 'mongodb' extension in the CI pipeline.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
composer.json Modified dependency constraints for mongodb/mongodb and removed conflict.
.github/workflows/pipeline.yml Introduced an environment variable to enforce the MongoDB PHP extension in tests.
Comments suppressed due to low confidence (2)

composer.json:43

  • Ensure that the change in the dependency constraint for mongodb/mongodb to include version 2.0 is aligned with the overall project compatibility requirements and that any potential conflicts in other parts of the code are updated as needed.
        "mongodb/mongodb": "^1.21 || ^2.0",

.github/workflows/pipeline.yml:5

  • The introduction of the REQUIRED_PHP_EXTENSIONS environment variable ensures that the MongoDB extension is available during tests; verify that this configuration is applied consistently across all related CI jobs.
  REQUIRED_PHP_EXTENSIONS: 'mongodb'

@OskarStark OskarStark changed the title Allow mongodb:2.0 Allow mongodb/mongodb 2.0 Jun 24, 2025
Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OskarStark 👍

@chr-hertel chr-hertel merged commit 076ff69 into main Jun 24, 2025
7 checks passed
@chr-hertel chr-hertel deleted the mongodb2 branch June 24, 2025 15:16
chr-hertel added a commit to symfony/ai that referenced this pull request Jun 30, 2025
This PR was merged into the main branch.

Discussion
----------

chore: allow mongodb/mongodb 2.0 (#341)

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| Docs?         | no
| Issues        |
| License       | MIT

Cherry picking php-llm/llm-chain#341

Commits
-------

aad5b53 chore: allow mongodb/mongodb 2.0 (#341)
symfony-splitter pushed a commit to symfony/ai-store that referenced this pull request Jul 11, 2025
This PR was merged into the main branch.

Discussion
----------

chore: allow mongodb/mongodb 2.0 (#341)

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| Docs?         | no
| Issues        |
| License       | MIT

Cherry picking php-llm/llm-chain#341

Commits
-------

aad5b53 chore: allow mongodb/mongodb 2.0 (#341)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow/Handle MongoDB 2.0
2 participants