Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

fix: recursively remove additionalProperties from Gemini requests #351

Merged
merged 1 commit into from
Jun 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions src/Platform/Bridge/Google/Contract/ToolNormalizer.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,34 @@ protected function supportsModel(Model $model): bool
*/
public function normalize(mixed $data, ?string $format = null, array $context = []): array
{
$parameters = $data->parameters;
unset($parameters['additionalProperties']);

return [
'functionDeclarations' => [
[
'description' => $data->description,
'name' => $data->name,
'parameters' => $parameters,
'parameters' => $data->parameters ? $this->removeAdditionalProperties($data->parameters) : null,
],
],
];
}

/**
* @template T of array
*
* @phpstan-param T $data
*
* @phpstan-return T
*/
private function removeAdditionalProperties(array $data): array
{
unset($data['additionalProperties']); // not supported by Gemini

foreach ($data as &$value) {
if (\is_array($value)) {
$value = $this->removeAdditionalProperties($value);
}
}

return $data;
}
}
9 changes: 9 additions & 0 deletions tests/Platform/Bridge/Google/Contract/ToolNormalizerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ public static function normalizeDataProvider(): iterable
'type' => 'integer',
'description' => 'Number parameter',
],
'nestedObject' => [
'type' => 'object',
'description' => 'bar',
'additionalProperties' => false,
],
],
'required' => ['text', 'number'],
'additionalProperties' => false,
Expand All @@ -102,6 +107,10 @@ public static function normalizeDataProvider(): iterable
'type' => 'integer',
'description' => 'Number parameter',
],
'nestedObject' => [
'type' => 'object',
'description' => 'bar',
],
],
'required' => ['text', 'number'],
],
Expand Down