This repository was archived by the owner on Jul 16, 2025. It is now read-only.
fix: resolve array tool arguments #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
force-pushed
the
fix-array-tool-arguments
branch
from
13a82bf to
f3dd191
Compare
|
Thanks! I think there is some room to improve overall this denormalization, to support object arrays and other things that Symfony normally supports. Probably would need to use typeinfo instead of raw reflection |
chr-hertel
added a commit
to symfony/ai
that referenced
this pull request
Jul 4, 2025
This PR was merged into the main branch. Discussion ---------- fix: resolve array tool arguments | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | | License | MIT Cherry picking php-llm/llm-chain#368 Commits ------- 8bd22e8 fix: resolve array tool arguments (#368)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@valtzu any idea about this case?
found it after merging #359 with example examples/toolbox/tavily.php
patch feels a bit hacky, but does the job atm