This repository was archived by the owner on Jul 16, 2025. It is now read-only.
feat: allow JsonSerializable objects in contract #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DZunke
force-pushed
the
allow-json-serializable-objects-in-contract
branch
from
326a130 to
052e287
Compare
OskarStark
approved these changes
Jul 5, 2025
chr-hertel
approved these changes
Jul 5, 2025
|
Release needed 😅 |
chr-hertel
added a commit
to symfony/ai
that referenced
this pull request
Jul 6, 2025
This PR was merged into the main branch. Discussion ---------- feat: allow JsonSerializable objects in contract | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | no | Issues | | License | MIT Cherry picking php-llm/llm-chain#377 Commits ------- 9dde800 feat: allow JsonSerializable objects in contract (#377)
symfony-splitter
pushed a commit
to symfony/ai-platform
that referenced
this pull request
Jul 11, 2025
This PR was merged into the main branch. Discussion ---------- feat: allow JsonSerializable objects in contract | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | no | Issues | | License | MIT Cherry picking php-llm/llm-chain#377 Commits ------- 9dde800 feat: allow JsonSerializable objects in contract (#377)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As brought up in #371 it could be a possible extension point to the contract to reintroduce the support for
JsonSerializableobjects when there are no normalizers for an object.So it would be a possible alternative for custom
MessageBagInterface,MessageInterface,ContentInterface, etc. by allowing them to implement theJsonSerializableinterface.