McpServiceProvider File And loadElements function are not found #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michabbb
pushed a commit
to michabbb/php-mcp-laravel
that referenced
this pull request
Jun 10, 2025
…uth compliance ## Critical Transport Architecture Fix This commit resolves two fundamental issues that prevented MCP HTTP transport from working correctly with traditional PHP servers (PHP-FPM, Apache) while maintaining compatibility with long-running processes (ReactPHP). ### 🔧 Problem 1: Client Registration Lost Between Requests **Root Cause:** Each HTTP request in PHP-FPM/Apache runs in a separate PHP process, causing: - SSE stream (GET /sse) creates LaravelHttpTransport instance php-mcp#1 - POST requests (/message) create LaravelHttpTransport instance php-mcp#2 - Client registered in instance php-mcp#1 is not available in instance php-mcp#2 - Result: "Client not actively managed by this transport" errors **Solution:** Auto-registration in `LaravelHttpTransport::sendToClientAsync()`: - Automatically emit `client_connected` event for unknown clients - Ensures clients are active before processing messages - Maintains backward compatibility with ReactPHP (no-op for already active clients) ### 🔧 Problem 2: OAuth Standard Compliance **Root Cause:** Original package used non-standard parameter naming that violates OAuth spec: - Used: `clientId` (camelCase) - OAuth Standard: `client_id` (snake_case) - Real MCP clients (Claude Desktop) send `client_id` parameter **Solution:** - Updated SSE endpoint to accept `client_id` query parameter - Consistent `client_id` usage in all log messages - Maintains fallback to session ID if no `client_id` provided ### 🔧 Problem 3: Service Provider Architecture **Root Cause:** Multiple controller instantiations called `server->listen()` repeatedly, causing: - Event handlers registered multiple times - Transport state inconsistencies - Memory leaks and performance issues **Solution:** - Moved `server->listen()` to McpServiceProvider singleton registration - Removed redundant `server->listen()` calls from controller constructor - Proper logger injection in service provider ## 🧪 Tested Scenarios ✅ **PHP-FPM/Apache (Separate Processes)** - Each request gets clean transport instance - Auto-registration ensures client connectivity - No shared state issues ✅ **ReactPHP (Long-Running Process)** - Existing clients remain active - Auto-registration is no-op for active clients - No performance impact ✅ **Claude Desktop Integration** - Recognizes all MCP tools correctly - Proper `client_id` parameter handling - SSE stream maintains connection ## 🔍 Technical Details **Modified Files:** - `src/Transports/LaravelHttpTransport.php`: Auto-registration logic - `src/Http/Controllers/McpController.php`: OAuth compliance + service provider cleanup - `src/McpServiceProvider.php`: Centralized transport initialization **Key Changes:** 1. Auto-registration in `sendToClientAsync()` when client not found 2. SSE endpoint accepts `client_id` query parameter 3. Service provider handles transport listening lifecycle 4. Consistent `client_id` logging throughout ## 🚀 Impact **Before:** MCP HTTP transport only worked with ReactPHP **After:** Works with all PHP server configurations **Deployment:** Zero breaking changes - existing code continues to work **Performance:** Minimal overhead (~1 isset() check per message) This fix enables MCP HTTP transport to work reliably in production PHP environments while maintaining the existing API and functionality. Fixes issues with: - Traditional PHP-FPM deployments - Apache mod_php configurations - Docker containers with nginx+php-fpm - Shared hosting environments - Any setup where each HTTP request runs in separate PHP process Co-authored-by: Claude (Anthropic) <claude@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.