mark password as a sensitive param for 8.2 #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remicollet
force-pushed
the
issue-sensitive
branch
from
5630cb6 to
74919b0
Compare
remicollet
commented
Jun 21, 2022
php_memcached.c
Outdated
| @@ -3895,9 +3895,14 @@ PHP_METHOD(MemcachedServer, on) | |||
|
|
|||
| #endif | |||
|
|
|||
| #if PHP_VERSION_ID < 80200 | |||
There was a problem hiding this comment.
this should be defined only for 8.0/8.1, but needed for 7.x because of php/php-src#8842
|
Note: You'll likely need to update this PR due to php/php-src@342e18f which removes the |
|
Refreshed for upcoming 8.2.0beta1 |
|
CI is not related to this PR, so suashed and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice: this imply to use 8.2 to generate arginfo.