Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve: Create migration for drop table if a entire schema is deleted from OpenAPI spec #4

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

Resolve: Create migration for drop table if a entire schema is deleted from OpenAPI spec #4

wants to merge 64 commits into from

Conversation

SOHELAHMED7
Copy link
Member

Fix cebe#132

Fix #2

PR in fork: SOHELAHMED7#29

SOHELAHMED7 and others added 30 commits July 7, 2023 15:46
@SOHELAHMED7
Initial commit of this PR
40e7c8f
@SOHELAHMED7
Add failing test
186045d
@SOHELAHMED7
WIP
242ecde
@SOHELAHMED7
Merge branches 'master' and '132-create-migration-for-drop-table-if-a…
1a6a516 
…-entire-schema-is-deleted-from-open-api-spec' of github.com:SOHELAHMED7/yii2-openapi into 132-create-migration-for-drop-table-if-a-entire-schema-is-deleted-from-open-api-spec
@SOHELAHMED7
Design: WIP
c489f22
@SOHELAHMED7
WIP
d4e0d88
@SOHELAHMED7
WIP
be52231
@SOHELAHMED7
WIP
6c7e792
@cebe
Update README.md
56d4bb5 
note for moved package
@SOHELAHMED7
Create attributes from column schemas and more - WIP
8d047c5
@SOHELAHMED7
Create delete file (migration) containing important DB statements for…
9d901c9 
… drop table
@SOHELAHMED7
Cleanup
6427a61
@SOHELAHMED7
Fix style
aa9ca71
@SOHELAHMED7
Generate foreign keys in migrations - WIP
46ef387
@SOHELAHMED7
Create PK using Yii's in-built method
67cc5a0
@SOHELAHMED7
Create PK using Yii's in-built method - more concrete
c205866
@SOHELAHMED7
Fix php-openapi#2
2d10ff4
@SOHELAHMED7
Cleanup
6644d15
@SOHELAHMED7
Test cleanup
d45f911
@SOHELAHMED7
Fix issue of migration ordering in drop + fix failing tests
7cf9aa3
@SOHELAHMED7
Fix another failing tests
fbb2e8c
@SOHELAHMED7
Fix another failing tests - 2
7d7dba7
@SOHELAHMED7
Fix another failing tests - 3
51ebfd7
@SOHELAHMED7
Fix another failing tests - 4
0dbad7c
@SOHELAHMED7
Fix another failing tests - EnumTest::testAddNewColumn
72b927b
@SOHELAHMED7
Fix another failing tests - EnumTest::testChangeToAndFromEnum
ad7b022
@SOHELAHMED7
Fix another failing tests - ForeignKeyColumnNameTest::testIndex
07b00b1
@SOHELAHMED7
Fix another failing tests - ForeignKeyColumnNameTest::testIndexForCol…
0c552ce 
…umnWithCustomName
@SOHELAHMED7
Fix another failing tests - GeneratorTest::testGenerate
ba2ef56
@SOHELAHMED7
Fix another failing tests - NewColumnPositionTest::testAddOneNewColum…
3a1499b 
…nAtFirstPosition
@SOHELAHMED7
Polish
d9bad2e
@SOHELAHMED7
Fix style
2976125
@SOHELAHMED7
Merge pull request #29 from SOHELAHMED7/132-create-migration-for-drop…
b7d6b94 
…-table-if-a-entire-schema-is-deleted-from-open-api-spec

Resolve - Create migration for drop table if a entire schema is deleted from OpenAPI spec
@SOHELAHMED7
Merge branch 'cebe:master' into master
08998f6
@SOHELAHMED7 SOHELAHMED7 requested a review from cebe June 26, 2024 14:27
@SOHELAHMED7 SOHELAHMED7 marked this pull request as draft June 26, 2024 14:28
@SOHELAHMED7 SOHELAHMED7 changed the title Resolve: Create migration for drop table if a entire schema is deleted from OpenAPI spec Draft: Create migration for drop table if a entire schema is deleted from OpenAPI spec Jun 26, 2024
@SOHELAHMED7
Copy link
Member Author

Changing status to Draft to clean up few unwanted changes

@SOHELAHMED7 SOHELAHMED7 changed the title Draft: Create migration for drop table if a entire schema is deleted from OpenAPI spec Resolve: Create migration for drop table if a entire schema is deleted from OpenAPI spec Jun 26, 2024
@SOHELAHMED7 SOHELAHMED7 marked this pull request as ready for review June 26, 2024 14:42
@SOHELAHMED7
Copy link
Member Author

Changing status to Ready for review

@SOHELAHMED7 SOHELAHMED7 self-assigned this Jun 27, 2024
@SOHELAHMED7 SOHELAHMED7 mentioned this pull request Jul 4, 2024
Open
@SOHELAHMED7
Undo disable sorting for non dependent models
48e07b2
@SOHELAHMED7
Add test for independent tables drop sort
cf12d6f
@SOHELAHMED7
Revert "Fix another failing tests - MultiDbSecondaryMigrationTest"
74ca15a 
This reverts commit a4dc0a4.
@SOHELAHMED7
Revert "Fix another failing tests - NewColumnPositionTest::testAddOne…
9932d26 
…NewColumnAtFirstPosition"

This reverts commit 3a1499b.
@SOHELAHMED7
Revert "Fix another failing tests - GeneratorTest::testGenerate"
bed7fbb 
This reverts commit ba2ef56.
@SOHELAHMED7
Revert "Fix another failing tests - ForeignKeyColumnNameTest::testInd…
b08a7dc 
…exForColumnWithCustomName"

This reverts commit 0c552ce.
@SOHELAHMED7
Revert "Fix another failing tests - ForeignKeyColumnNameTest::testIndex"
73d36d3 
This reverts commit 07b00b1.
@SOHELAHMED7
Revert "Fix another failing tests - EnumTest::testChangeToAndFromEnum"
8d835c0 
This reverts commit ad7b022.
@SOHELAHMED7
Revert "Fix another failing tests - EnumTest::testAddNewColumn"
1c0f3b6 
This reverts commit 72b927b.
@SOHELAHMED7
Revert "Fix another failing tests - 4"
9fdc293 
This reverts commit 0dbad7c.
@SOHELAHMED7
Revert "Fix another failing tests - 3"
38682f1 
This reverts commit 51ebfd7.
@SOHELAHMED7
Revert "Fix another failing tests - 2"
e19fffb 
This reverts commit 7d7dba7.
@SOHELAHMED7
Revert "Fix another failing tests"
60df77f 
This reverts commit fbb2e8c.
@SOHELAHMED7
Revert "Fix issue of migration ordering in drop + fix failing tests"
8b1876f 
This reverts commit 7cf9aa3.
@SOHELAHMED7
Fix failing tests
1c86e8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebe cebe cebe left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@SOHELAHMED7 SOHELAHMED7

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SOHELAHMED7 @cebe