Resolve: Create migration for column position change if a field position is changed in spec #58 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…add column) (for one or more columns) + Fix failing tests
SOHELAHMED7
changed the title
cebe
approved these changes
Nov 12, 2024
lets keep it like this, order is not super important. |
cebe
deleted the
58-create-migration-for-column-position-change-if-a-field-position-is-changed-in-spec
branch
|
Thank you! |
|
FYI: I moved tests for this issue to a separate file: tests/unit/Issue58FixTest.php |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #58.
This pull request does not cover the case: lot of new columns are added, lot of columns are deleted and lot of columns are moved at different positions.
Because current state of library first compute all columns to create, drop and alter and then builds migrations (e.g. compiled languages).
In order to fix above issue, we should consider columns one by one and build its migration (e.g. interpreted languages). This will require lot of changes in current library and lot of changes in existing tests.