Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let JSON Schema Store to do the config validation #256

Closed
2 tasks done
stasadev opened this issue Nov 10, 2023 · 3 comments · Fixed by #269
Closed
2 tasks done

Let JSON Schema Store to do the config validation #256

stasadev opened this issue Nov 10, 2023 · 3 comments · Fixed by #269
Assignees
Labels
bug Something isn't working

Comments

@stasadev
Copy link

stasadev commented Nov 10, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Are you sure that this bug is related to this DDEV Integration Plugin?

  • I am sure

Enter your error report ID (If available)

No response

Describe the bug

From Discord:

image

Following up the discussion

This plugin should let the Schema Store JSON to do the validation:

Steps to reproduce

No response

Additional context

No response

@stasadev stasadev added the bug Something isn't working label Nov 10, 2023
@stasadev stasadev changed the title Add web_extra_exposed_ports to JSON schema Use JSON Schema Store for config validation Nov 10, 2023
@stasadev stasadev changed the title Use JSON Schema Store for config validation Let JSON Schema Store to do the config validation Nov 10, 2023
@nico-loeber
Copy link
Contributor

Will be done for the next release.

If someone likes to pull request it:

@nico-loeber nico-loeber linked a pull request Dec 7, 2023 that will close this issue
@nico-loeber nico-loeber self-assigned this Dec 7, 2023
@nico-loeber
Copy link
Contributor

Done, the schema provider is removed from the plugin and the one from the ddev repository is used.
This change will be part of the next release of the plugin targeting PHPStorm 2023.3.

@mandrasch
Copy link

Nice, thanks very much! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants