-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DDEV project config schema #3158
Conversation
Do you want to include both project and global in this PR @jamesmacwhite ? |
I'm not sure we can because of the fileMatch rule logic, given the path to the global config is a $HOME path, which I don't think the fileMatch logic can handle, as it seems geared towards project specific or relative to a project folder. I'd love to get feedback on this from the schemastore maintainers however to confirm if something like if it possible I'll happily submit a separate one, just as it's two different schema files, so just for being neat about it. |
@jamesmacwhite Your |
Feel free to submit all DDEV schemas in this single PR! It's probably easier to keep track of them that way. |
@hyperupcall Thanks for your quick response! That's great to hear! I'll add the global config as well! Just to confirm the fileMatch rules align:
The global config path would be something like Would these rules align accordingly? |
Just a note @jamesmacwhite - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Match all config*.yaml
Also please add global config per discussion.
85ce7c8
to
0e213aa
Compare
Thanks! I've added the ddev global config schema and updated the fileMatch files accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great to me, thanks!
@jamesmacwhite Yes! And as far as I understand it, |
@jamesmacwhite Is this ready to be merged? |
@hyperupcall Thank you. Yes, all the schemas are ready! @rfay (DDEV maintainer) is happy I believe! |
Awesome, thank you |
Congrats on a bunch of great work and initiative @jamesmacwhite , thanks for the amazing responsiveness @hyperupcall 🚀 |
Thanks everyone! |
Hello!
I would like to contribute an addition to the schemastore project for the DDEV project config configuration file schema.
Discussing with the maintainer of DDEV, self hosting the schema within DDEV makes the most sense to ensure configuration options and changes are able to be made accordingly per releases. Before self hosting the schema was tested against a valid config.yaml file and passes strict validation tests. However as we are self hosting the schema was cannot utilise these tests I don't think, but we are looking to implement these into CI process within DDEV itself.
Schema reference: https://raw.githubusercontent.com/ddev/ddev/master/pkg/ddevapp/schema.json
Reading the contributing guidelines and because this is a new schema, I believe adding a URL rerference is only required, looking at other examples, but do let me know if there's anything further needed!
@rfay @nico-loeber