Skip to content

Correct mapRequest() to include query string in $uri #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kentr opened this issue Feb 18, 2016 · 0 comments
Closed

Correct mapRequest() to include query string in $uri #8

kentr opened this issue Feb 18, 2016 · 0 comments

Comments

@kentr
Copy link
Collaborator

kentr commented Feb 18, 2016

Problem / motivation

See here for background.

The problem case: POST requests that also have query string values in the URI.

Expected results

  • Request::$request contains the POST data.
  • Request::$query contains the query string data.

Actual results

Since, in the case of POST requests, the $parameters parameter contains only the POST data, the query string values will be missed unless they're included in $uri (IOW, only the POST data will be see by create()).

Suggested fix

Request::create() uses any query string values that are included the $uri parameter when building its $query values.

To fix the problem, add the query string to the $uri when calling create().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant