Skip to content

[suggestion] Symfony Bundle option? #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndrewCarterUK opened this issue Mar 23, 2016 · 3 comments
Closed

[suggestion] Symfony Bundle option? #29

AndrewCarterUK opened this issue Mar 23, 2016 · 3 comments

Comments

@AndrewCarterUK
Copy link

Hello,

Thank you for your work on this - it was a great inspiration for a project of mine (PHPFastCGI) that I've had much enjoyment and success with.

My suggestion is for you to provide a bundle integration for your project to the Symfony framework. You can use the container to retrieve the kernel as a service (for handling requests) and you can insert console commands directly into the application.

I can see that this set up allows you to bootstrap Symfony and Laravel - and my suggestion would only work for Symfony, but the ease of installation makes it a very appealing option. Getting going is as simple as composer requiring a bundle, adding it to the kernel, and away you go - a process Symfony users are very familiar with.

I've already done this with PHPFastCGI: Speedfony Bundle so this may be a useful reference for you.

Anyway, keep up the good work - and I won't be offended if you close this for not being a route that you want to go down :)

@marcj
Copy link
Member

marcj commented Mar 23, 2016

Hey @AndrewCarterUK, thank you very much for your feedback! highly appreciated :)

We went the other path, by initialize the kernel ourselves, so we had full access to the kernel. The good part about this is, that the user does not need to modify its application in any way (at least in theory 😄 memory leaks will result in a modifications nonetheless).

Did you get any limitation with your PHPFastCGI? I ask because I guess we do currently the same work (reading cookies, headers, request body and pass it into a SymfonyRequest, and then vice-versa SymfonyResponse to http output). I'm not sure whether we can eliminate some work by just merging our projects together, if possible, so that PPM spawns little fastcgi server, that do the same, so we don't need to fully implement http/1.1,2 specs.

@AndrewCarterUK
Copy link
Author

The main limitation I've had is handling uploaded files. I'm not sure if it's a limitation as much as something that I just haven't got around to!

I'm currently developing (with React PHP, Icicle and AMP) an interoperable application event loop that would allow for better support of async programming techniques (returning a response promise for example). This could eventually become a FIG PSR (check here).

I'm also very happy to look into the possibility of sharing some of the work load between our projects. My current focus is on async support as I think this will change quite significantly how our projects are structured (if you decide this is something you'd like to support too).

@andig
Copy link
Contributor

andig commented Jan 29, 2018

Uploaded file handling should meanwhile be working as well- closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants